-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4641, #4674, #4579, #4591: Assorted beta fixes #4685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the existing parameter for automatic updates with one general to all downloads. It does not include gating the side menu as that would require more refactoring (and will be done in a future, non-time sensitive PR).
The changes are fairly self explanatory, I think, but I'll follow up with a clearer description & tests in the next 1-2 days. |
Conflicts: app/src/main/java/org/oppia/android/app/profile/AddProfileViewModel.kt app/src/main/res/values-ar/strings.xml testing/src/main/java/org/oppia/android/testing/platformparameter/TestPlatformParameterModule.kt
The tests were accidentally disabled before, so they didn't reveal the classifier itself needed to also change.
@seanlip PTAL. As an FYI I have also self-reviewed the whole PR. |
seanlip
approved these changes
Nov 9, 2022
Thanks, took a pass. No concerns. |
Assigning @rt4914 for code owner reviews. Thanks! |
6 tasks
This was referenced Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #4641
Fixes #4674
Fixes #4579
Fixes #4591
Miscellaneous fixes for Beta MR2. Specifically:
Test exemption: FakeAssetRepository doesn't have a test added since it uses a real production AssetRepository, and tests don't yet exist for that). They ought to be tested together.
Essential Checklist
For UI-specific PRs only
Screenshots showing the before & after changes due to hiding downloads options:
Espresso test rules for affected UI tests:
New Robolectric tests failing for corresponding regressions:
Missing artifacts: